Skip to content

fix(test): disable solid HMR in tests to fix path error on Windows (@nadalaba)#7677

Merged
Miodec merged 1 commit intomonkeytypegame:masterfrom
nadalaba:fix-jsx-tests-windows
Mar 22, 2026
Merged

fix(test): disable solid HMR in tests to fix path error on Windows (@nadalaba)#7677
Miodec merged 1 commit intomonkeytypegame:masterfrom
nadalaba:fix-jsx-tests-windows

Conversation

@nadalaba
Copy link
Contributor

@nadalaba nadalaba commented Mar 18, 2026

Description

Solid’s refresh runtime is injecting a virtual module that resolves to an invalid file:///@ URL causing tests to fail on Windows:

TypeError: The argument 'filename' must be a file URL object, file URL string, or absolute path string. Received 'file:///@solid-refresh'

HMR isn’t used in vitest's SSR test environment, so disabling it on all platforms is safe.

@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label Mar 18, 2026
@Miodec Miodec merged commit e37252b into monkeytypegame:master Mar 22, 2026
17 checks passed
@nadalaba nadalaba deleted the fix-jsx-tests-windows branch March 22, 2026 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend User interface or web stuff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants